Add Mavis Market to nft.trades #7355
Conversation
github-actions
bot
added
WIP
Added Ronin
…nin/platforms/_schema.yml to dbt_subprojects/nft/models/_sector/trades/chains/ronin/nft_ronin_base_trades.sql
github-actions
bot
added
ready-for-review
There was a problem hiding this comment.
Left some questions/comments around data QA.
It would also be nice to add a seed test to the model.
You can see how that is done for collectionswap here:
seed: https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/nft/seeds/trades/base_trades/collectionswap_ethereum_base_trades_seed.csv
schema:
spellbook/dbt_subprojects/nft/seeds/trades/base_trades/_schema.yml
Lines 196 to 206 in 6a2d09f
test:
| quantity as nft_amount, | ||
| seller, | ||
| buyer, | ||
| '' as trade_category, |
There was a problem hiding this comment.
This should be 'Buy' or 'Sell'.
If it's not possible to determine the trade direction, feel free to just set 'Buy' as the default.
| seller, | ||
| buyer, | ||
| '' as trade_category, | ||
| '' as trade_type, |
There was a problem hiding this comment.
This should be 'secondary'
| cast(json_extract_scalar(replace(json_extract_scalar(json_parse(json_extract_scalar("order", '$.info')),'$.assets[0]'),'\\', ''),'$.erc') as double) as erc, | ||
| FROM_HEX(json_extract_scalar(replace(json_extract_scalar(json_parse(json_extract_scalar("order", '$.info')),'$.assets[0]'),'\\', ''),'$.addr')) as nft_contract_address, | ||
| cast(json_extract_scalar(replace(json_extract_scalar(json_parse(json_extract_scalar("order", '$.info')),'$.assets[0]'),'\\', ''),'$.id') as double) as nft_token_id, | ||
| cast(json_extract_scalar(replace(json_extract_scalar(json_parse(json_extract_scalar("order", '$.info')),'$.assets[0]'),'\\', ''),'$.quantity') as double) as quantity, |
There was a problem hiding this comment.
This seems to return 0 in quite some cases, it should always be 1 or greater
| contract_address as project_contract_address, | ||
| tx_hash, | ||
| platform_address as platform_fee_address, | ||
| platform_fee_amount_raw, |
There was a problem hiding this comment.
This always returns 200 currently which seems to be the ratio and not the actual raw value?
| -- axie_fee_amount_raw, | ||
| -- ronin_treasury_fee_amount_raw, |
There was a problem hiding this comment.
if you want, you can keep these in this model.
They won't make it into nft.trades but at least they'll be available in the project specific model.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: